8354489: Some callers of VMError::report_and_die think it can return by Sorna-Sarathi · Pull Request #32054 · openjdk/jdk

Sorna-Sarathi · 2026-07-27T13:49:01Z

VMError::report_and_die is [[noreturn]] and cannot return, even when UseOSErrorReporting is enabled.

Remove misleading comments and dead code from report_error(os_windows.cpp) and report_vm_out_of_memory (debug.cpp).

JBS Issue: JDK-8354489

I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

JDK-8354489: Some callers of VMError::report_and_die think it can return (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32054/head:pull/32054
$ git checkout pull/32054

Update a local copy of the PR:
$ git checkout pull/32054
$ git pull https://git.openjdk.org/jdk.git pull/32054/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32054

View PR using the GUI difftool:
$ git pr show -t 32054

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32054.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2026-07-27T13:50:55Z

👋 Welcome back ssarathi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2026-07-27T13:52:11Z

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

openjdk · 2026-07-27T13:53:14Z

@Sorna-Sarathi The following label will be automatically applied to this pull request:

hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

openjdk · 2026-07-27T13:53:18Z

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot. This can be overridden with the /reviewers command.

mlbridge · 2026-07-27T13:57:16Z

Webrevs

offamitkumar

LGTM.

dholmes-ora

Looks good but one further change requested. Thanks

dholmes-ora · 2026-07-28T04:02:27Z

 static inline void report_error(Thread* t, DWORD exception_code,
                                address addr, void* siginfo, void* context) {


Just an observation but this helper method has served no purpose since JDK-8080775 changed the VMError code back in JDK 9.

If so, we should remove it.

Done. I've updated.

dholmes-ora · 2026-07-28T04:06:23Z

@@ -240,10 +240,6 @@ void report_vm_out_of_memory(const char* file, int line, size_t size,

  VMError::report_and_die(Thread::current_or_null(), file, line, size, vm_err_type, detail_fmt, detail_args);
  va_end(detail_args);


The va_end is also unreachable and should also be deleted.

I'm a little suprised the compiler doesn't complain about code after a noreturn method call.

Hmm actually this occurs in a number of places, so we should either change all or none. So I think leave this for a separate issue.

Yeah, I've already thought about that. As you said, it occurs in other functions too. So, I didn't remove here for consistency.

I am not sure if va_end can be omitted. Could it lead to undefined behavior?

dholmes-ora · 2026-07-28T04:18:25Z

There are other places that need fixing not mentioned in the JBS issue e.g. there are PosixSignals::pd_hotspot_signal_handler definitions which follow it with a ShouldNotReachHere().

dholmes-ora · 2026-07-28T04:22:06Z

I think this needs some discussion we have a lot of conservative use of ShouldNotReachHere() after the calls, which are semantically equivalent to the guarantee that has been flagged here. So either they all need to be removed or they all stay.

tstuefe

This looks mostly good to me, if you remove the report_error function David mentioned.

tstuefe · 2026-07-28T05:23:12Z

 static inline void report_error(Thread* t, DWORD exception_code,
                                address addr, void* siginfo, void* context) {


If so, we should remove it.

offamitkumar

@Sorna-Sarathi there were couple of function calls in os_windows.cpp, to the function you just removed report_error, as you see in the build-failure log. You should update those calls with VmError::report_and_die.

openjdk · 2026-07-28T07:38:49Z

@Sorna-Sarathi Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

8354489:Remove misleading comments

cb8e5b2

openjdk Bot added the hotspot hotspot-dev@openjdk.org label Jul 27, 2026

openjdk Bot added the rfr Pull request is ready for review label Jul 27, 2026

offamitkumar approved these changes Jul 28, 2026

View reviewed changes

dholmes-ora suggested changes Jul 28, 2026

View reviewed changes

tstuefe reviewed Jul 28, 2026

View reviewed changes

Address review comments

df847c8

offamitkumar suggested changes Jul 28, 2026

View reviewed changes

openjdk Bot removed the rfr Pull request is ready for review label Jul 28, 2026

Inline report_error calls

4e311dc

Sorna-Sarathi force-pushed the JDK-8354489-cleanup branch from 2ea9a00 to 4e311dc Compare July 28, 2026 07:38

openjdk Bot added the rfr Pull request is ready for review label Jul 28, 2026

Fix report_and_error

4a59eca

		static inline void report_error(Thread* t, DWORD exception_code,
		address addr, void* siginfo, void* context) {

		@@ -240,10 +240,6 @@ void report_vm_out_of_memory(const char* file, int line, size_t size,

		VMError::report_and_die(Thread::current_or_null(), file, line, size, vm_err_type, detail_fmt, detail_args);
		va_end(detail_args);

Uh oh!

Conversation

Sorna-Sarathi commented Jul 27, 2026 • edited by openjdk Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewing

Uh oh!

bridgekeeper Bot commented Jul 27, 2026

Uh oh!

openjdk Bot commented Jul 27, 2026

Uh oh!

openjdk Bot commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk Bot commented Jul 27, 2026

Uh oh!

mlbridge Bot commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

offamitkumar left a comment

Choose a reason for hiding this comment

Uh oh!

dholmes-ora left a comment

Choose a reason for hiding this comment

Uh oh!

dholmes-ora Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

tstuefe Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

Sorna-Sarathi Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

dholmes-ora Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

dholmes-ora Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sorna-Sarathi Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

iklam Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

dholmes-ora commented Jul 28, 2026

Uh oh!

dholmes-ora commented Jul 28, 2026

Uh oh!

tstuefe left a comment

Choose a reason for hiding this comment

Uh oh!

tstuefe Jul 28, 2026

Choose a reason for hiding this comment

Uh oh!

offamitkumar left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openjdk Bot commented Jul 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

Sorna-Sarathi commented Jul 27, 2026 •

edited by openjdk Bot

Loading

openjdk Bot commented Jul 27, 2026 •

edited

Loading

mlbridge Bot commented Jul 27, 2026 •

edited

Loading

dholmes-ora Jul 28, 2026 •

edited

Loading

offamitkumar left a comment •

edited

Loading